Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API compat instructions to libraries building README #113088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephentoub
Copy link
Member

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 3, 2025 18:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds instructions to the README for handling API compatibility errors during the library build process. The key change is the inclusion of guidance on suppressing API compatibility errors by re-invoking the dotnet pack command with a special argument when expected breaking changes occur.

  • Added documentation outlining the API compatibility error and suppression steps.

Reviewed Changes

File Description
docs/workflow/building/libraries/README.md Documentation update to guide handling of API compatibility errors

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@ericstj ericstj requested a review from ViktorHofer March 3, 2025 18:14
@@ -256,3 +256,7 @@ Same as for `dotnet build` or `dotnet publish`, you can specify the desired conf
```cmd
dotnet.cmd pack src\libraries\System.Text.Json\src\ -c Release
```

If changes to the library include any API incompatibilities, calling `dotnet pack` will result in API compatibility errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer will this work for framework libraries like System.Runtime / System.Net.Http / etc? Do we need to cover that case separately?

Copy link
Member

@ViktorHofer ViktorHofer Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non packable projects under src/libraries run APICompat as part of the dotnet build command. I think that needs to be documented separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants