Fix test failure from #113051 #113128
Merged
Fix test failure from #113051 #113128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures GT_NEG -> GT_CAST contained by a comparison node forces the node being casted into a register during lowering, to avoid trying to generate code for an incompatible memory operation.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
reviewed
Mar 4, 2025
| // cmn (extended-register): GT_EQ -> GT_NEG -> GT_CAST -> ... | ||
| cast = op->gtGetOp1(); | ||
| } | ||
| if (cast) |
There was a problem hiding this comment.
nit: use curly braces
if (cast)
{
cast->AsCast()->CastOp()->ClearRegOptional();
}There was a problem hiding this comment.
@snickolls-arm - I will let you fix this in subsequent PR
|
/ba-g infra issue dotnet/dnceng#5144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures GT_NEG -> GT_CAST contained by a comparison node forces the node being casted into a register during lowering, to avoid trying to generate code for an incompatible memory operation.