Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APICompat doesn't catch changing existing member to abstract #47166

Open
ericstj opened this issue Feb 27, 2025 · 1 comment
Open

APICompat doesn't catch changing existing member to abstract #47166

ericstj opened this issue Feb 27, 2025 · 1 comment
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@ericstj
Copy link
Member

ericstj commented Feb 27, 2025

Describe the bug

See discussion here dotnet/maintenance-packages#205 (comment)

To Reproduce

Make a package with a netstandard2.0 implementation with method not abstract. Have a compatible framewwork with the same member but abstract.

Expect: CannotAddAbstractMember diagnostic

Actual: No diagnostic. 
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Feb 27, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

@ericstj ericstj mentioned this issue Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericstj