Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all container information is available from MSBuild in publicly-supported structures #622

Closed
baronfel opened this issue Feb 27, 2025 · 0 comments · Fixed by dotnet/sdk#47234
Assignees

Comments

@baronfel
Copy link
Member

@mcumming was using our tech to build containers but wanted to power detections based on the digest of the base image. Initially, I suggested that he read the ContainerLabel items after the publish to find the base image and use that - however we do not actually create the matching Item, we only synthesize it during the image creation. We should ensure that this is added to the MSBuild environment when we create the rest of the CreateNewImage Task's Outputs.

In addition, he bound to the _PublishSingleContainer Target because that target contained the structure with the generated configuration, which he could then dig into. We should instead ensure that the PublishContainer target Returns the same structures that _PublishSingleContainer and _PublishMultiArchContainers does so that the same 'entry point' can be consumed regardless of publishing style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant