[9.0.3xx] Add analyzer redirecting VSIX #47021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR backports analyzer redirection changes to insert a VSIX component in Visual Studio 17.14. The changes include adding a new task to generate runtime analyzers SWR files, implementing analyzer assembly redirection logic, and introducing tests that verify redirection based on version compatibility.
Reviewed Changes
| File | Description |
|---|---|
| src/Installer/core-sdk-tasks/GenerateRuntimeAnalyzersSWR.cs | Adds a new task for generating a runtime analyzers SWR file with folder and file inclusion logic |
| test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs | Introduces tests to validate analyzer redirection across different version scenarios |
| src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs | Implements redirection logic that maps analyzer assembly names to their redirected paths and builds an analyzer map |
| src/Microsoft.Net.Sdk.AnalyzerRedirecting/AnalyzerRedirectingPackage.cs | Provides a minimal package definition for VS integration |
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs
Show resolved
Hide resolved
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42861 so it can be inserted into VS 17.14.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/575718