-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove underscore from _UseManagedNtlm
#47141
base: main
Are you sure you want to change the base?
Conversation
cc @filipnavara, @wfurt, @rzikm |
I'm torn about this. Technically you are right. It should have never made the documentation with the current name and the ship has sailed on that. Changing the name now will make the documentation invalid and also any usage of the property in the wild. I still consider the option to be an unsupported compatibility hack which happens to be useful for testing or workarounds. I'll defer the decision to others, but thanks for tagging me and keeping me in the loop! |
I did a quick GitHub search and didn't find any projects using the There's a usage in dotnet/runtime that would have to be updated if this goes through: |
I'm OK either way. We can always document it as breaking change to make it more visible. I would think the need for this is small now.... |
I am on the same page as wfurt. |
Sounds good. We can take this change and update the doc with |
Now that it's documented https://learn.microsoft.com/dotnet/api/system.net.networkcredential#remarks and no longer an internal property, lets make it consistent with rest of the config options (without the leading underscore).