Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/windowsdesktop #47167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from dotnet/windowsdesktop #47167

wants to merge 4 commits into from
+20 −20

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 27, 2025 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Sdk.WindowsDesktop: from 10.0.0-preview.3.25120.2 to 10.0.0-preview.3.25127.1 (parent: Microsoft.WindowsDesktop.App.Ref)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 10.0.0-preview.2.25118.5 to 10.0.0-preview.3.25125.6 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 10.0.0-preview.3.25120.2 to 10.0.0-preview.3.25127.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

From https://github.com/dotnet/windowsdesktop

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Feb 27, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@build-analysis build-analysis bot mentioned this pull request Feb 28, 2025
Open
@v-wuzhai
Copy link
Member

@dotnet/product-construction Could you take a look at the VMR failures here?

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 28, 2025 •
edited
Loading

@Tanya-Solyanik isn't the failure here the one that was a false positive in roslyn? Please take a look.

https://github.com/dotnet/winforms/blame/342d09f48df8ef5dab1d061e8c26d765da235fd4/src/System.Private.Windows.Core/src/System/Private/Windows/Nrbf/SerializationRecordExtensions.cs#L328

dotnet/winforms#12881

@dotnet-maestro @Tanya-Solyanik
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
1d376b6 
…ld 20250227.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-preview.3.25126.4 -> To Version 10.0.0-preview.3.25127.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 10.0.0-preview.3.25120.2 -> To Version 10.0.0-preview.3.25127.1 (parent: Microsoft.WindowsDesktop.App.Ref
@Tanya-Solyanik Tanya-Solyanik force-pushed the darc-main-b4f51743-e654-49f7-86df-56693d303c42 branch from dd1f85e to 1d376b6 Compare March 5, 2025 01:47
@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Mar 5, 2025 •
edited
Loading

@ViktorHofer - yes, it is the same issue, why does VMR builds run against stale dependencies?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
184cf35 
…ld 20250304.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-preview.3.25126.4 -> To Version 10.0.0-preview.3.25154.1
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 5, 2025 •
edited
Loading

The compiler being used that emits the error is on this commit: dotnet/roslyn@6908aea (data from the binlog)

So the compiler doesn't have dotnet/roslyn@ff40252 which is the fix. We will need a re-bootstrap. I will trigger that.

why does VMR build run against stale dependencies?

This isn't special to the VMR. Repositories build with a .NET toolset SDK and that's just too old.

Winforms doesn't build with live roslyn because there's no dependency defined (it doesn't need to and would make the graph more complex):

sdk/src/SourceBuild/content/repo-projects/winforms.proj

Lines 13 to 16 in f472045

<ItemGroup>
<RepositoryReference Include="arcade" />
<RepositoryReference Include="runtime" />
</ItemGroup>

@ViktorHofer
Copy link
Member

#47290 should unblock this

@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
b8dd178 
…ld 20250305.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-preview.3.25126.4 -> To Version 10.0.0-preview.3.25155.1
@edvilme
Copy link
Member

edvilme commented Mar 7, 2025

Track #47359

@dotnet-maestro
Update dependencies from https://github.com/dotnet/windowsdesktop bui…
55fc860 
…ld 20250307.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0
 From Version 10.0.0-preview.3.25126.4 -> To Version 10.0.0-preview.3.25157.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ViktorHofer ViktorHofer

Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @ViktorHofer @Tanya-Solyanik @edvilme