Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Skip attribute from tests related to issue #47246 #47247

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Remove Skip attribute from tests related to issue #47246 #47247

merged 1 commit into from
Mar 4, 2025

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Mar 4, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 4, 2025 06:03
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 4, 2025
@v-wuzhai v-wuzhai requested a review from marcpopMSFT March 4, 2025 06:03
Copilot
Copilot AI reviewed Mar 4, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Skip attribute for a test in PackTests.cs to reference a GitHub issue URL, indicating the reason for skipping the test.

  • Updated the Skip attribute message in the PackAddsCorrectFilesForProjectsWithOutputNameSpecified test.

Reviewed Changes

File Description
test/dotnet-pack.Tests/PackTests.cs Changed the Skip attribute message to reference an issue URL.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

test/dotnet-pack.Tests/PackTests.cs:107

  • [nitpick] Consider adding a brief explanation alongside the issue URL in the Skip attribute to clarify the reason for skipping the test.
[Fact(Skip = "https://github.com/dotnet/sdk/issues/47246")]
@baronfel
Copy link
Member

baronfel commented Mar 4, 2025

Thanks for this @v-wuzhai

@baronfel baronfel merged commit 4ca66e1 into main Mar 4, 2025
41 checks passed
@baronfel baronfel deleted the dev/Jason/Remove-skip-attribute-issue-47246 branch March 4, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@baronfel baronfel

@Forgind Forgind

@marcpopMSFT marcpopMSFT

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-wuzhai @baronfel @Forgind