Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the DemoConsole application multi-targeted to both .NET and .NET Framework #12830

Open
Olina-Zhang opened this issue Jan 23, 2025 · 4 comments · May be fixed by #12996
Open

Make the DemoConsole application multi-targeted to both .NET and .NET Framework #12830

Olina-Zhang opened this issue Jan 23, 2025 · 4 comments · May be fixed by #12996
Assignees
@ricardobossan
Labels
🚧 work in progress Work that is current in progress test-enhancement Improvements of test source code
Milestone
.NET 10.0

Comments

@Olina-Zhang
Copy link
Member

Olina-Zhang commented Jan 23, 2025 •
edited by Tanya-Solyanik
Loading

.NET version

10.0.100-alpha.1.25072.10

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Not an issue, need to modify DemoConsole application with multi-targeted

Issue description

Make the DemoConsole application in Winforms repo multi-targeted to both .NET and .NET Framework so that we can validate where we've got regressions from NetFX
@Olina-Zhang Olina-Zhang added untriaged The team needs to look at this issue in the next triage test-enhancement Improvements of test source code labels Jan 23, 2025
@Olina-Zhang Olina-Zhang mentioned this issue Jan 23, 2025
Closed
@Tanya-Solyanik Tanya-Solyanik removed the untriaged The team needs to look at this issue in the next triage label Jan 23, 2025
@Tanya-Solyanik Tanya-Solyanik added this to the .NET 10.0 milestone Jan 23, 2025
@Tanya-Solyanik Tanya-Solyanik mentioned this issue Jan 29, 2025
Closed
73 tasks
@ricardobossan ricardobossan mentioned this issue Feb 6, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Feb 6, 2025
@ricardobossan
Copy link
Member

@Tanya-Solyanik @LeafShi1 @Epica3055

I created PR #12885 to show my current approach for making DemoConsole multi-targeted.

However, the build fails with the following errors:

PS C:\Users\v-rbossan\winforms> .\Restore.cmd;.\build.cmd
Variable NativeToolsOnMachine detected, enabling native tool path promotion...
Processing C:\Users\v-rbossan\winforms\global.json
  C:\.tools\.nuget\packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.25074.4\tools\Tools.proj             Restore (0.7s)
  Runtime toolset 'dotnet/x64 v10.0.0-preview.2.25104.8' already installed.                                      (1.3s)
Restauração concluída (1.3s)
  Winforms falhou com 4 erro(s) (0.4s)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Drawing.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Drawing.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Windows.Forms.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Windows.Forms.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Windows.Forms não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Windows.Forms dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)

Construir falhou com 4 erro(s) em 3.7s
Build failed with exit code 1. Check errors above.
Variable NativeToolsOnMachine detected, enabling native tool path promotion...
Processing C:\Users\v-rbossan\winforms\global.json
  C:\.tools\.nuget\packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.25074.4\tools\Tools.proj             Restore (0.7s)
  Runtime toolset 'dotnet/x64 v10.0.0-preview.2.25104.8' already installed.                                      (1.3s)
Restauração concluída (1.3s)
  Winforms falhou com 4 erro(s) (0.2s)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Drawing.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Drawing.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Windows.Forms.Design não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Windows.Forms.Design dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)
    C:\Users\v-rbossan\winforms\src\System.Windows.Forms\tests\IntegrationTests\DesignSurface\DesignSurfaceExt\DesignSurfaceExt.csproj : error NU1201: O projeto System.Windows.Forms não é compatível com net462 (.NETFramework,Version=v4.6.2). O projeto System.Windows.Forms dá suporte a: net10.0 (.NETCoreApp,Version=v10.0)

Construir falhou com 4 erro(s) em 4.8s
Build failed with exit code 1. Check errors above.

It looks like some dependencies aren't resolving correctly for net462. I’ve checked previous PRs related to multi-targeting but haven’t found a clear solution.

Is there an existing approach for handling this, or should we explore alternative strategies?

@Tanya-Solyanik
Copy link
Member

It does not have to be net462, it could be 4.8.1 to test against the latest. Does the version make a difference?

@LeafShi1
Copy link
Member

LeafShi1 commented Feb 6, 2025

It does not have to be net462, it could be 4.8.1 to test against the latest. Does the version make a difference?

Using net481 will also fail to build, because other projects referenced in project Demo are based on net10, such as System.Windows.Forms.Design.csproj.

If it is not referenced when TargetFramework=net481, Error1 will appear, and if it is referenced, Error2 will appear
Error1：
Image
Error2:
Image

@Tanya-Solyanik
Copy link
Member

The .NET Framework version of the build can't reference the solution projects, it should reference the GAC'd assemblies instead. This assembly should be replaced by System.Design and System.Drawing.Design

@ricardobossan ricardobossan linked a pull request Feb 24, 2025 that will close this issue
Open
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Feb 27, 2025
Related dotnet#12830
dd7e2ce 
- Sets `DesignerSerializationVisibility` to `Hidden` in `PropertyGridExt.DesignerHost`

- None

- No

- Minimal

- Manual

- 10.0.100-preview.3.25125.5
ricardobossan added a commit that referenced this issue Mar 3, 2025
@ricardobossan
Related #12830. Sets DesignerSerializationVisibility to Hidden in…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
882cea2 
… `PropertyGridExt.DesignerHost` (#13043)

Related #12830

- Sets `DesignerSerializationVisibility` to `Hidden` in `PropertyGridExt.DesignerHost`

- None

- No

- Minimal

- Manual

- 10.0.100-preview.3.25125.5

Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
LeafShi1 pushed a commit to LeafShi1/winforms that referenced this issue Mar 6, 2025
@ricardobossan @LeafShi1
Related dotnet#12830. Sets DesignerSerializationVisibility to `Hidd…
9d22f59 
…en` in `PropertyGridExt.DesignerHost` (dotnet#13043)

Related dotnet#12830

- Sets `DesignerSerializationVisibility` to `Hidden` in `PropertyGridExt.DesignerHost`

- None

- No

- Minimal

- Manual

- 10.0.100-preview.3.25125.5

Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Mar 6, 2025
Updated DemoConsole.csproj and DesignSurfaceExt.csproj to support…
0193c58 
… multiple target frameworks (`$(NetCurrent)-windows;net481`)

Fixes dotnet#12830

- Updated `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to support multiple target frameworks (`$(NetCurrent)-windows;net481`).
- Adjusted `TargetFramework` property to avoid over-building.
- Enabled `SignAssembly` and `GenerateAssemblyInfo` properties in the project files.
- Updated resource and reference handling in `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to improve compatibility.
- Fixed `Controls.AddRange` usage to use the correct syntax in `MainForm.MyUserControl.cs`.
- Corrected `Controls.AddRange` call in `MainForm.cs` to `Controls.Add`.
- Suppressed `IDE0057` warning and reverted to `Substring` method for compatibility in `NameCreationServiceImp.cs`.
- Changed `StartsWith('_')` check by directly accessing the first character in `NameCreationServiceImp.cs` for compatibility.
- Disabled error `CA1824` for projects `DemoConsole` and `DesignSurficeExt`, because it would be triggered even though properly configured in those projects, according to the fix provided by the [documentation](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1824#fix-violations).

- None

- No

- Minimal

- `DemoConsole` would not run on `net481`.

- Manual

- 10.0.100-alpha.1.25077.2
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Mar 7, 2025
Updated DemoConsole.csproj and DesignSurfaceExt.csproj to support…
9db5536 
… multiple target frameworks (`$(NetCurrent)-windows;net481`).

Fixes dotnet#12830

- Updated `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to support multiple target frameworks (`$(NetCurrent)-windows;net481`).
- Adjusted `TargetFramework` property to avoid over-building.
- Enabled `SignAssembly` and `GenerateAssemblyInfo` properties in the project files.
- Updated resource and reference handling in `DemoConsole.csproj` and `DesignSurfaceExt.csproj` to improve compatibility.
- Fixed `Controls.AddRange` usage to use the correct syntax in `MainForm.MyUserControl.cs`.
- Corrected `Controls.AddRange` call in `MainForm.cs` to `Controls.Add`.
- Suppressed `IDE0057` warning and reverted to `Substring` method for compatibility in `NameCreationServiceImp.cs`.
- Changed `StartsWith('_')` check by directly accessing the first character in `NameCreationServiceImp.cs` for compatibility.
- Disabled error `CA1824` for projects `DemoConsole` and `DesignSurficeExt`, because it would be triggered even though properly configured in those projects, according to the fix provided by the [documentation](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1824#fix-violations).

- None

- No

- Minimal

- `DemoConsole` would not run on `net481`.

- Manual

- 10.0.100-preview.3.25125.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardobossan ricardobossan

Labels
🚧 work in progress Work that is current in progress test-enhancement Improvements of test source code
Projects
None yet
Milestone
.NET 10.0
Development

Successfully merging a pull request may close this issue.

Issue 12830 multi target demo console ricardobossan/winforms
4 participants
@Tanya-Solyanik @Olina-Zhang @ricardobossan @LeafShi1