Code Coverage for DownloadFile Review 1St #12486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12486 +/- ##
===================================================
+ Coverage 76.10589% 76.31910% +0.21321%
===================================================
Files 3275 3282 +7
Lines 643778 646956 +3178
Branches 47441 47624 +183
===================================================
+ Hits 489953 493751 +3798
+ Misses 150263 149637 -626
- Partials 3562 3568 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 tasks
Cleanup
Move test constants to separate module for future reuse
Move some constants around Rename some files that are shared between upload and download
Improve code coverage for upload tests Support more real File Server options
…internal implementation. Use TypeResolver to load SystemConfiguration and add sample configuration for real servers. Add tests for leading ServerConfiguration json files.
Improve coverage Fix cancelation logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace corrupt PR12221
Proposed changes
Customer Impact
Regression?
Risk
-None
Test environment(s)
Microsoft Reviewers: Open in CodeFlow