[release/8.0] Fix 12850 error provider exception in different dpi #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sets icon size with ScaleHelper, for the ErrorProvider component. --------- Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
…est (dotnet#10847) Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
LeafShi1
changed the title
LeafShi1
changed the title
Tanya-Solyanik
added
🚫 * NO-MERGE *
src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/ErrorProviderTest.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
removed
the
waiting-for-testing
Tanya-Solyanik
previously approved these changes
Feb 13, 2025
JeremyKuhne
approved these changes
Mar 5, 2025
JeremyKuhne
added
servicing-consider
LeafShi1
removed
the
🚫 * NO-MERGE *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port pr #10850 and pr #12947 to release8.0
Fixes #12850 and #12939
Bug Description
The PR #8486 removed
new Icon(icon, 16 ,16)fromIconRegionconstructor, that causes the released icon object to be directly referenced, so there is an exceptionCannot access a disposed object. Object name: 'Icon'.Backport #10850 fixes the above problem, but the PR always scaled
IconRegionto 100% DPI, so it causes issue #12939: The icon of errorProvider is not scaled well on HDPI screen, so backport #12947 to scale the ErrorProvider'sIconRegionaccording to the current device DPI.Customer Impact
Regression?
Risk
Testing
Microsoft Reviewers: Open in CodeFlow