Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability in ContainerSelectorBehavior #12961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable nullability in ContainerSelectorBehavior #12961

wants to merge 1 commit into from

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Feb 16, 2025 •
edited by dotnet-policy-service bot
Loading

Proposed changes

  • Enable nullability in ContainerSelectorBehavior.
Microsoft Reviewers: Open in CodeFlow

@gpetrou gpetrou requested a review from a team as a code owner February 16, 2025 06:43
@Tanya-Solyanik
Copy link
Member

src\System.Windows.Forms.Design\src\System\Windows\Forms\Design\ControlDesigner.cs#L669

src\System.Windows.Forms.Design\src\System\Windows\Forms\Design\ControlDesigner.cs(669,69): error CS8604: (NETCORE_ENGINEERING_TELEMETRY=Build) Possible null reference argument for parameter 'serviceProvider' in 'ContainerSelectorBehavior.ContainerSelectorBehavior(Control containerControl, IServiceProvider serviceProvider)'.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 17, 2025
@gpetrou gpetrou force-pushed the ContainerSelectorBehavior branch 2 times, most recently from abb0433 to 43c499b Compare February 22, 2025 06:57
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.94502%. Comparing base (4bcc8a9) to head (ac5bedd).

Additional details and impacted files 
@@                 Coverage Diff                  @@
##                main      #12961          +/-   ##
====================================================
- Coverage   96.95044%   74.94502%   -22.00542%     
====================================================
  Files           1225        3275        +2050     
  Lines         357134      643812      +286678     
  Branches        5537       47446       +41909     
====================================================
+ Hits          346243      482505      +136262     
- Misses         10049      152469      +142420     
- Partials         842        8838        +7996
Flag Coverage Δ
Debug 74.94502% <47.05882%> (-22.00543%) ⬇️
production 47.53138% <47.05882%> (?)
test 96.95044% <ø> (ø)
unit 47.53138% <47.05882%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Tanya-Solyanik
Tanya-Solyanik reviewed Feb 26, 2025
View reviewed changes
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs Outdated
{
if (_moveBehavior is null)
{
if (Component.Site is null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pattern matching to avoid invoking Component.Site property twice.

@gpetrou gpetrou force-pushed the ContainerSelectorBehavior branch from 43c499b to ac5bedd Compare March 3, 2025 07:17
@gpetrou gpetrou requested a review from Tanya-Solyanik March 4, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-Solyanik Tanya-Solyanik

At least 1 approving review is required to merge this pull request.

Assignees

@gpetrou gpetrou

Labels
area: NRT waiting-author-feedback The team requires more information from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpetrou @Tanya-Solyanik