Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewDesigner #13014

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Feb 24, 2025

Related #10773

Proposed changes

Add unit test file: DataGridViewDesignerTests.cs for public methods of the DataGridViewDesigner.cs, except for OnAddColumn and OnEditColumns methods.

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.17003%. Comparing base (227fd3b) to head (b278975).
Report is 46 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13014         +/-   ##
===================================================
+ Coverage   76.04966%   76.17003%   +0.12036%     
===================================================
  Files           3269        3276          +7     
  Lines         643544      643891        +347     
  Branches       47429       47446         +17     
===================================================
+ Hits          489413      490452       +1039     
+ Misses        150566      149885        -681     
+ Partials        3565        3554         -11     
Flag Coverage Δ
Debug 76.17003% <100.00000%> (+0.12036%) ⬆️
integration 18.13486% <ø> (+0.09766%) ⬆️
production 50.27471% <ø> (+0.24329%) ⬆️
test 96.95092% <100.00000%> (+0.01366%) ⬆️
unit 47.60019% <ø> (+0.11296%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 24, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 25, 2025
@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 25, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 26, 2025
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 27, 2025
@Zheng-Li01 Zheng-Li01 removed the waiting-author-feedback The team requires more information from the author label Feb 27, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 27, 2025
@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 27, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Feb 28, 2025
@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 28, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Mar 3, 2025
ricardobossan
ricardobossan previously approved these changes Mar 3, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit a5c88fa into dotnet:main Mar 6, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Mar 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Mar 6, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_covrage_for_DataGridViewDesignerTests branch March 6, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants