-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ToolStripAdornerWindowService #13029
base: main
Are you sure you want to change the base?
Add unit tests for ToolStripAdornerWindowService #13029
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13029 +/- ##
====================================================
- Coverage 75.75455% 61.32004% -14.43451%
====================================================
Files 3159 1525 -1634
Lines 635942 158025 -477917
Branches 46987 14712 -32275
====================================================
- Hits 481755 96901 -384854
+ Misses 150726 60434 -90292
+ Partials 3461 690 -2771
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request adds unit tests for the ToolStripAdornerWindowService to validate its public properties and methods along with enabling nullability in the tests.
- Introduces multiple tests covering graphics, coordinate translation, and resource disposal.
- Provides STA-thread execution for tests that interact with UI components.
Reviewed Changes
File | Description |
---|---|
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs | Contains new unit tests for verifying ToolStripAdornerWindowService behavior and proper handling of designer overlays and graphics. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Outdated
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
...rms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripAdornerWindowServiceTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow