Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for DataGridViewColumnTypePicker #13055

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Mar 3, 2025

Related #10773

Proposed changes

Add unit test file: DataGridViewColumnTypePicker.cs for public methods of the DataGridViewColumnTypePicker.cs

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner March 3, 2025 01:37
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08310%. Comparing base (61a4f2a) to head (9975f82).
Report is 26 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13055          +/-   ##
====================================================
- Coverage   76.10018%   61.08310%   -15.01708%     
====================================================
  Files           3275        1540        -1735     
  Lines         643804      158083      -485721     
  Branches       47445       14727       -32718     
====================================================
- Hits          489936       96562      -393374     
+ Misses        150301       60827       -89474     
+ Partials        3567         694        -2873     
Flag Coverage Δ
Debug 61.08310% <100.00000%> (-15.01708%) ⬇️
integration 10.73772% <ø> (-7.30089%) ⬇️
production 38.89160% <ø> (-11.23329%) ⬇️
test 95.67350% <100.00000%> (-1.27694%) ⬇️
unit 36.31426% <ø> (-11.24391%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 3, 2025
@ricardobossan ricardobossan requested a review from Copilot March 3, 2025 23:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds unit tests for the DataGridViewColumnTypePicker class to improve code coverage.

  • Introduces a new test file with various tests for control initialization, property setting, and event handling.
  • Verifies that the picker initializes its ListBox correctly, sets visual properties, and handles type selection appropriately.

Reviewed Changes

File Description
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewColumnTypePickerTests.cs New unit tests to validate the behavior of DataGridViewColumnTypePicker

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 6, 2025
@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Mar 6, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 8691d0e into dotnet:main Mar 6, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Mar 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Mar 6, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_For_DataGridViewColumnTypePicker branch March 7, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants