Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional Identity/Login Providers? #337

Closed
cccs-tom opened this issue Sep 20, 2021 · 16 comments · Fixed by #838
Closed

Support for additional Identity/Login Providers? #337

cccs-tom opened this issue Sep 20, 2021 · 16 comments · Fixed by #838
Assignees
Labels
priority:medium server Component: server

Comments

@cccs-tom
Copy link

My team wishes to use one or more IdP that are not GitHub or Eclipse. Our immediate use case is for Azure AD, but we will likely want to use an on-prem IdP (likely Keycloak) at some point in the future as well.

We would be looking (for the time being) at making it possible to change the IdP to something other than GitHub, but not addign support for multiple IdP. Is this something that you would be interested in having us contribute back to your code base?

@amvanbaren
Copy link
Contributor

+1 for Keycloak. It would be nice to decouple user management from the registry.

@spoenemann spoenemann added the server Component: server label Sep 22, 2021
@spoenemann
Copy link
Member

Yes, support for more authentication providers is definitely in the scope of this project, and contributions are welcome!

There is one challenge, though: we currently have a home-grown login handling because we need to support both GitHub and Eclipse OAuth login for the public instance running at open-vsx.org. If it's possible, I would be ok with a solution that keeps the current implementation for the public instance, but switches to something more generic for other instances (this could be controlled via application.yml properties).

@cccs-tom
Copy link
Author

@spoenemann Sure, we can definitely work with that! Thanks.

@rangav
Copy link

rangav commented Mar 28, 2022

I prefer simple email/username and password login

@zlweicoder
Copy link

Any follow up?
+1 for Keycloak!
thanks~

@amvanbaren
Copy link
Contributor

@zlweicoder I have a working prototype/draft for Keycloak integration. It's been a couple months since I last worked on it. I'll commit the changes and link the branch here. Maybe somebody else can pick it up.

@amvanbaren
Copy link
Contributor

This is the Keycloak integration branch: https://github.com/amvanbaren/openvsx/tree/feature/issue-337

@guddu121
Copy link

Hi There,

Is there any plan to merge the keycloak branch with openvsx and there are lot of dependencies and changes has been done. If someone can pick do it then would be great.

@guddu121
Copy link

HI Amvanbaren,

I want to know any plan in coming days to integrate the branch with keycloak support into openvsx

@amvanbaren
Copy link
Contributor

Hi @guddu121, no there are currently no plans to merge the keycloak branch with openvsx. AFAIK this feature is still a prototype/draft. @zlweicoder did you work on keycloak integration?

@krithika2689
Copy link

krithika2689 commented Nov 30, 2022

Hi @amvanbaren @zlweicoder ,
In my company , we were able to successfully fork the keycloak integration branch @amvanbaren had posted , run it locally and configure a simple login flow using basic auth.Our goal is to implement Gitlab Auth for OpenVSX.We have the following two options :

  1. With Keycloak :
    If this feature branch (whihc is now quite behind "master" ) can be merged to "master" with all conflicts resolved. We will be happy to test it in our environment and fix any bugs that come up.

  2. Without keycloak :
    IF there is no intention to bring keycloak branch upto master , then we will implement gitlab auth on top of the current "master" and will be happy to contribute that back as well.

Please let us know your recommendation

@zlweicoder
Copy link

Hi @guddu121, no there are currently no plans to merge the keycloak branch with openvsx. AFAIK this feature is still a prototype/draft. @zlweicoder did you work on keycloak integration?

sorry, I haven't had a chance working on it yet.

@ChevronTango
Copy link

We're very keen to host our own copy of OpenVSX and have it work with our self hosted GitLab. I'd rather not have to fork the project. Any word on when we can expect this? Auth with GitHub and Eclipse alone does not work for us.

@kineticsquid
Copy link
Contributor

@ChevronTango Glad to see you and your team are interested. We'd love to see you all take the work on the branch @amvanbaren mentions above and finish it off in your deployment. Comeback with your findings and possibly a PR. Right now finishing this work simply isn't a priority for us.

@kineticsquid
Copy link
Contributor

Also, wanted to make sure you'd seen this announcement about the future of open-vsx.org: https://blogs.eclipse.org/post/john-kellerman/help-us-sustain-open-vsxorg

@HeikoBoettger
Copy link

Can may be somebody have a look at #838?
This would greatly improve the support of additional providers.

@amvanbaren amvanbaren linked a pull request Feb 27, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from On Hold to Done in Eclipse Open VSX Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium server Component: server
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants