Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e sync command fails due to git root mistmatch (Windows 10) #588

Open
andrewsml opened this issue May 6, 2024 · 2 comments · May be fixed by #589
Open

e sync command fails due to git root mistmatch (Windows 10) #588

andrewsml opened this issue May 6, 2024 · 2 comments · May be fixed by #589
Labels
🪲 bug Something isn't working

Comments

@andrewsml
Copy link

this happen by running e sync command.
it compares two pathes and the only difference is that C: drive is in uppercase

________ running 'python3 build/config/siso/configure_siso.py --rbe_instance projects/rbe-chrome-untrusted/instances/default_instance' in 'c:\workspace\electron_release'
gclient(1967) _WriteFileContents:Writing to file c:\workspace\electron_release\.gclient_previous_sync_commits
ERROR Expected git root to be c:\workspace\electron_release\src\electron but found C:\workspace\electron_release\src\electron

Operating System

Windows 10 22H2

Expected Behavior

e sync succeeds
@andrewsml andrewsml changed the title e sync command fails due to git root mistmatch e sync command fails due to git root mistmatch (Windows 10) May 6, 2024
@MarshallOfSound
Copy link
Member

I assume we need some kind of path.normalize around cwd as well here -->

build-tools/src/e-sync.js

Lines 21 to 23 in 6cfcc75

if (gitRoot !== cwd) {
fatal(`Expected git root to be ${cwd} but found ${gitRoot}`);
}

You can try fiddling with that part of build-tools locally and submit a PR if you can make it work? Build tools is working fine on my windows machine so it's probably something specific to your set up? File system, node version, git version, etc.

andrewsml added a commit to andrewsml/build-tools that referenced this issue May 6, 2024
@andrewsml
fix: e sync, compare pathes with no case (electron#588)
cfdc99c
@andrewsml
Copy link
Author

@MarshallOfSound , alright. I made a pull request, thanks

@codebytere codebytere linked a pull request May 6, 2024 that will close this issue
Open
andrewsml added a commit to andrewsml/build-tools that referenced this issue May 8, 2024
@andrewsml
fix: e sync, compare pathes with no case on Windows (electron#588)
66bde25
@MarshallOfSound MarshallOfSound mentioned this issue May 25, 2024
Closed
@codebytere codebytere added the 🪲 bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: e sync, compare paths with no case andrewsml/build-tools
3 participants
@codebytere @MarshallOfSound @andrewsml