feat!: bump engines requirement to Node 22
#1167
Open
+1,087
−789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
force-pushed
the
feat/node-22
branch
from
9e52f83 to
bc19e91
Compare
erikian
force-pushed
the
feat/node-22
branch
from
931e82b to
5e5336d
Compare
felixrieseberg
approved these changes
Feb 27, 2025
| @@ -0,0 +1,2 @@ | |||
| *.d.ts | |||
There was a problem hiding this comment.
Interesting! I'm not against it, just surprised that eslint can't handle d.ts files.
| @@ -102,7 +102,7 @@ for Electron Packager. For example: | |||
|
|
|||
| ```javascript | |||
| import packager from '@electron/packager'; | |||
| import rebuild from '@electron/rebuild'; | |||
| import { rebuild } from '@electron/rebuild'; | |||
| @@ -155,7 +155,7 @@ const childProcess = require('child_process'); | |||
| const pathToElectron = require('electron'); | |||
|
|
|||
| rebuild({ | |||
| buildPath: __dirname, | |||
| buildPath: import.meta.dirname, | |||
There was a problem hiding this comment.
I wonder if we should document both here, I know that the __dirname vs import.meta.dirname thing keeps tripping people up quite a bit.
| "got": "^11.7.0", | ||
| "graceful-fs": "^4.2.11", |
There was a problem hiding this comment.
Appreciate it, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bumps required Node.js version to
>=22.12.0. ESM-only.I also took the opportunity to update
farmhashto3.3.1in one of the test fixtures so we can run a couple of test cases we were skipping onarm64macOS. I tried switching to4.0.1but it would require some deeper changes in the tests, so I figured it would be a good idea to address that in a follow-up PR as3.3.1is enough to get those tests running for the Node upgrade.