Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline code baseline issues #749

Closed
nikwen opened this issue Jan 27, 2025 · 5 comments · Fixed by #771
Closed

Inline code baseline issues #749

nikwen opened this issue Jan 27, 2025 · 5 comments · Fixed by #771
Labels
area:docs Related to rendering the documentation

Comments

@nikwen
Copy link
Contributor

nikwen commented Jan 27, 2025

The baseline for inline code is weird on the Electron docs website. Words are placed "too low".

Image

Source

Browser: Firefox 134.0.2 on macOS 15.2
@erickzhao erickzhao added the area:docs Related to rendering the documentation label Jan 28, 2025
@dv2202
Copy link
Contributor

dv2202 commented Mar 2, 2025

i would want to work on this

@nikwen
Copy link
Contributor Author

nikwen commented Mar 2, 2025

@dv2202 Please go ahead and open a pull request!

@erickzhao erickzhao mentioned this issue Mar 3, 2025
Closed
@vishalshahh
Copy link

Can you assign this task to me

@nikwen
Copy link
Contributor Author

nikwen commented Mar 5, 2025

Just submit a PR. Electron doesn't assign issues to non-maintainers.

dv2202 added a commit to dv2202/website that referenced this issue Mar 5, 2025
@dv2202
style: fix inline code baseline alignment (electron#749)
810e732
@dv2202
Copy link
Contributor

dv2202 commented Mar 5, 2025

#771

@erickzhao erickzhao mentioned this issue Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:docs Related to rendering the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: fix inline code baseline alignment dv2202/website
4 participants
@nikwen @erickzhao @vishalshahh @dv2202