Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize the Project for Containerized Devlopment #769

Closed
jangirvipin opened this issue Mar 2, 2025 · 4 comments
Closed

Dockerize the Project for Containerized Devlopment #769

jangirvipin opened this issue Mar 2, 2025 · 4 comments

Comments

@jangirvipin
Copy link

Currently, this project is not Dockerized, making it difficult to ensure consistency across different environments. This issue aims to introduce a Docker setup that will containerize the application, enabling easier development, deployment, and scalability.

@jangirvipin
Copy link
Author

@nikwen Can i solve this issue ? If so then assign me .

@erickzhao
Copy link
Member

Currently, this project is not Dockerized, making it difficult to ensure consistency across different environments. This issue aims to introduce a Docker setup that will containerize the application, enabling easier development, deployment, and scalability.

I haven't had any issues with getting the project set up across different machines with the current installation instructions (use nvm -> install node/nvm -> yarn install -> run the website).

Can you elaborate on why this would be necessary for the project?

@jangirvipin
Copy link
Author

hey @erickzhao , yes you right this approach is also good , but we can use docker for several benefits
(1). No Need to Manually Install nvm. The Docker image includes everything needed.
(2) A single command (docker-compose up) is enough to start the project. but since this is a simple project , we can also use current approach .
(3). The same Docker image can be used for development, testing, and production.

Since local setup of this project is simple , there is no need of docker . But for better consistency and ease of use we can use docker.

@erickzhao
Copy link
Member

"Production" in this case is just a set of static HTML files being uploaded to blob storage. There's no server or app being run on production.

I don't think there are any benefits to containerization here for production or development here, so I'm going to close this issue.

@erickzhao erickzhao closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants