Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Electron 35 blog post #761

Merged
merged 10 commits into from
Mar 6, 2025
Merged

chore: add Electron 35 blog post #761

merged 10 commits into from
Mar 6, 2025

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Feb 25, 2025

This PR adds the blog post for Electron 35. @electron/wg-releases, @electron/wg-outreach

Merge target: March 4th, after 35.0.0 releases.

⚠️ Do not merge until the following are completed ⚠️

  • Update node, v8 and chromium versions from final chrome roll under Stack Changes section
  • Edit link for M134 "New In Chrome" blog post
  • Add a few bullets for New Features section
  • Add any missing items in Breaking Changes section
  • Update End of Support

Note: The "Check Blog links" job is going to fail until the Chrome 134 announcement blog comes out. A fail is expected until about Tuesday

@VerteDinde VerteDinde requested a review from a team as a code owner February 25, 2025 22:21
Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2025

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: b140ad4
Status: ✅  Deploy successful!
Preview URL: https://3332b867.electron-website.pages.dev
Branch Preview URL: https://e-35-blog-post.electron-website.pages.dev

View logs

Copy link
Member

@mlaurencin mlaurencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the change below is addressed

VerteDinde and others added 2 commits March 4, 2025 15:41
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
@VerteDinde VerteDinde requested a review from erickzhao March 4, 2025 23:41
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
@erickzhao erickzhao self-assigned this Mar 5, 2025
Copy link
Contributor

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the highlights!

console.log('Renderer unresponsive\n', callStack);
});
});
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting that the Document-Policy header also needs to be set. See electron/electron#45356.

@nikwen
Copy link
Contributor

nikwen commented Mar 6, 2025

I just noticed that both the dictionary APIs and WebFrameMain.collectJavaScriptCallStack() were already added in Electron v34. I don't think it makes sense listing them again.

Since you wrote such beautiful prose already, @erickzhao, you might want to move them to the v34 blog post instead.

Copy link
Contributor

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more formatting. Didn't look at these parts of the PR earlier.

erickzhao and others added 3 commits March 5, 2025 16:55
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
@erickzhao
Copy link
Member

erickzhao commented Mar 6, 2025

I just noticed that both the dictionary APIs and WebFrameMain.collectJavaScriptCallStack() were already added in Electron v34. I don't think it makes sense listing them again.
Since you wrote such beautiful prose already, @erickzhao, you might want to move them to the v34 blog post instead.

Oops, totally missed that! Took those from the bullet points we already had in the "Highlights" section 🙃.

b140ad4 removes those two PRs from the blog post and catches a few other PRs that were backported to later versions of 34.x.y.

@nikwen
Copy link
Contributor

nikwen commented Mar 6, 2025

Oops, totally missed that! Took those from the bullet points we already had in the "Highlights" section 🙃.

Thanks for the changes, @erickzhao! Yes, not your fault. Those were already in there before you wrote the beautiful prose.

(I think the prose for those two points was great though and it would make sense to add it retroactively to the v34 blog post.)

Copy link
Member

@clavin clavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@erickzhao erickzhao merged commit 287e489 into main Mar 6, 2025
4 checks passed
@erickzhao erickzhao deleted the e-35-blog-post branch March 6, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants