-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Electron 35 blog post #761
Conversation
Deploying electron-website with
|
Latest commit: |
b140ad4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3332b867.electron-website.pages.dev |
Branch Preview URL: | https://e-35-blog-post.electron-website.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the change below is addressed
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the highlights!
blog/electron-35-0.md
Outdated
console.log('Renderer unresponsive\n', callStack); | ||
}); | ||
}); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting that the Document-Policy
header also needs to be set. See electron/electron#45356.
I just noticed that both the dictionary APIs and Since you wrote such beautiful prose already, @erickzhao, you might want to move them to the v34 blog post instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more formatting. Didn't look at these parts of the PR earlier.
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
Oops, totally missed that! Took those from the bullet points we already had in the "Highlights" section 🙃. b140ad4 removes those two PRs from the blog post and catches a few other PRs that were backported to later versions of 34.x.y. |
Thanks for the changes, @erickzhao! Yes, not your fault. Those were already in there before you wrote the beautiful prose. (I think the prose for those two points was great though and it would make sense to add it retroactively to the v34 blog post.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
This PR adds the blog post for Electron 35. @electron/wg-releases, @electron/wg-outreach
Merge target: March 4th, after 35.0.0 releases.
Note: The "Check Blog links" job is going to fail until the Chrome 134 announcement blog comes out. A fail is expected until about Tuesday