Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tenv linter with usetesting #19485

Closed
ivanvc opened this issue Feb 26, 2025 · 3 comments · Fixed by #19488
Closed

Replace tenv linter with usetesting #19485

ivanvc opened this issue Feb 26, 2025 · 3 comments · Fixed by #19488
Assignees
@mmorel-35
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup

Comments

@ivanvc
Copy link
Member

ivanvc commented Feb 26, 2025 •
edited
Loading

What would you like to be added?

After the golagci-lint bump to 1.64.5, we started getting the following warning:

The linter 'tenv' is deprecated (since v1.64.0) due to: Duplicate feature another linter. Replaced by usetesting

We should replace the linter with usetesting to avoid future failures.

Refer to any recent pull-etcd-verify job, i.e., https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/19484/pull-etcd-verify/1894477775524335616#1:build-log.txt%3A114-119

Why is this needed?

To keep our linters up to date.
@ivanvc ivanvc added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup labels Feb 26, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Feb 26, 2025

@mmorel-35, are you interested in helping with this?

@mmorel-35
Copy link
Contributor

Yes !

@mmorel-35 mmorel-35 mentioned this issue Feb 26, 2025
Merged
@ivanvc
Copy link
Member Author

ivanvc commented Feb 26, 2025

/assign @mmorel-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorel-35 mmorel-35

Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/cleanup
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use usetesting instead of tenv mmorel-35/etcd
2 participants
@ivanvc @mmorel-35