[test] Add e2e downgrade automatic cancellation test

[henrybear327]

Verify that the downgrade can be cancelled automatically when the downgrade is completed (using no inflight downgrade job as the indicator)

Please see #19365 (comment)

Reference: #17976

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

---

Close #17976

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (9f1709e) to head (a927742).

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19399      +/-   ##
==========================================
+ Coverage   68.78%   68.83%   +0.05%     
==========================================
  Files         421      421              
  Lines       35901    35901              
==========================================
+ Hits        24693    24714      +21     
+ Misses       9781     9761      -20     
+ Partials     1427     1426       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1709e...a927742. Read the comment docs.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ahrtr]

LGTM

cc @fuweid @siyuanfoundation @serathius

[ahrtr]

@henrybear327 can you please rebase this PR ? I just merged #19398

[henrybear327]

@henrybear327 can you please rebase this PR ? I just merged #19398

Saw and done as you posted!

[ahrtr]

Please resolve the comments

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[henrybear327]

Is this PR still relevant as we are doing #19439?

[ahrtr]

Is this PR still relevant as we are doing #19439?

Yes, I think so. The auto downgrade cancel should still work.

[ahrtr]

FYI. #19451 (comment)

Thanks for the effort anyway. @henrybear327

[ahrtr]

FYI. #19451 (comment)

3.5 has the auto downgrade cancellation as well, so this test case still makes sense. @fuweid @henrybear327

https://github.com/etcd-io/etcd/blob/release-3.5/server/etcdserver/server.go#L2724

[ahrtr]

FYI. #19451 (comment)

3.5 has the auto downgrade cancellation as well, so this test case still makes sense. @fuweid @henrybear327

https://github.com/etcd-io/etcd/blob/release-3.5/server/etcdserver/server.go#L2724

But 3.5 doesn't have the downgrade status query API. So this PR should be independent to #19451. So there is no need to wait for that PR. @fuweid @henrybear327 @siyuanfoundation

[henrybear327]

FYI. #19451 (comment)

3.5 has the auto downgrade cancellation as well, so this test case still makes sense. @fuweid @henrybear327
https://github.com/etcd-io/etcd/blob/release-3.5/server/etcdserver/server.go#L2724

But 3.5 doesn't have the downgrade status query API. So this PR should be independent to #19451. So there is no need to wait for that PR. @fuweid @henrybear327 @siyuanfoundation

So ... is the conclusion to still merge this PR or no? Sorry that I am pretty lost during these exchanges.

[ahrtr]

So ... is the conclusion to still merge this PR or no?

YES. It's nice to merge this PR before next Tuesday. But it isn't a blocker for 3.6.0-rc.1.

[henrybear327]

So ... is the conclusion to still merge this PR or no?

YES. It's nice to merge this PR before next Tuesday. But it isn't a blocker for 3.6.0-rc.1.

Got it! I have rebased it now, but I will likely complete addressing all comments and incorporating changes regarding cancellation status by Monday noon (as I am out on both days on the weekend).

Marking the PR as a draft now.

[henrybear327]

/retest

[henrybear327]

Ready for a final pass!