-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooling for markdown linting #19425
base: main
Are you sure you want to change the base?
Tooling for markdown linting #19425
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Zanda256 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Zanda256. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f65e917
to
ea90940
Compare
/ok-to-test |
@ivanvc could we please give the failing tests a re-run? |
Yes, you can also do it by yourself by commenting: /retest Note: I haven't forgotten about this pull request, but I haven't been able to review it as I have other things in my backlog. I'll return to this soon ✌️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19425 +/- ##
==========================================
+ Coverage 68.78% 68.84% +0.06%
==========================================
Files 421 421
Lines 35901 35901
==========================================
+ Hits 24693 24716 +23
+ Misses 9781 9761 -20
+ Partials 1427 1424 -3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, @Zanda256. I'm sorry for not getting back to you sooner. I left a couple of comments/suggestions. Thanks again :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @Zanda256. Could you:
- Please add a new file
tools/.markdownlint.jsonc
? The contents of the file should be{}
- Squash your commits into a single one?
This is looking good. I tested locally and it works as expected, we just need these latest changes. Thanks again!
c869284
to
96ce211
Compare
96ce211
to
4d65163
Compare
5d54765
to
dfbce41
Compare
…nable markdown linting Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
dfbce41
to
f4e1d0e
Compare
With this pull request, we add a bash script to run linting check on modified or newly added markdown files. We then add a makefile target to run the script using make.
Partially resolves #18059