-
Notifications
You must be signed in to change notification settings - Fork 10.1k
etcdctl: fix json output #19469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: fix json output #19469
Conversation
Hi @kstrifonoff. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4de0af7
to
237116d
Compare
237116d
to
d39583f
Compare
/cc @ivanvc |
Hi @kstrifonoff, thanks for the pull request. I'm respectful to the original contributor who asked to work on this. Our guideline is to re-assign after a week of no answer when asking a contributor for updates. A couple of suggestions by quickly looking at the code.
Thanks again for your pull request :) |
240d3a0
to
b1cc94c
Compare
1510dc9
to
db2b56f
Compare
Hi @ivanvc , I’ve made some changes to my initial suggestions based on your feedback. Now, the “JSON with Hex” implementation is just a slight extension of the default “printJSON” implementation. I think it should probably be moved into the “utils” package. Here are a few things I noticed:
|
/ok-to-test |
The e2e tests already exist, my suggestion is to expand them to cover the new cases you added: etcd/tests/e2e/ctl_v3_member_test.go Lines 206 to 255 in 9f1709e
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19469 +/- ##
==========================================
- Coverage 69.28% 69.22% -0.06%
==========================================
Files 414 414
Lines 34408 34455 +47
==========================================
+ Hits 23840 23853 +13
- Misses 9180 9203 +23
- Partials 1388 1399 +11 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
59ffb52
to
d744c19
Compare
2e1a2cc
to
17b58b6
Compare
minor refactoring add unit tests Signed-off-by: Kirill Trifonov <kstrifonoff@gmail.com>
17b58b6
to
b42b5f9
Compare
/retest |
1 similar comment
/retest |
@kstrifonoff: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thx
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, kstrifonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivanvc did @kstrifonoff address your review ? |
Fix #19262
Example output of
etcdctl member add test-node --learner=true --peer-urls=http://127.0.0.1:22380 --write-out json --hex
command:Before:
After