-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use a more straightforward return value #19470
Conversation
Signed-off-by: beforetech <mail@before.tech>
Hi @beforetech. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 25 files with indirect coverage changes @@ Coverage Diff @@
## main #19470 +/- ##
==========================================
+ Coverage 68.84% 68.93% +0.09%
==========================================
Files 420 420
Lines 35762 35779 +17
==========================================
+ Hits 24622 24666 +44
+ Misses 9714 9686 -28
- Partials 1426 1427 +1 Continue to review full report in Codecov by Sentry.
|
Thanks for your review. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, beforetech, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
use a more straightforward return value