Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use a more straightforward return value #19470

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

beforetech
Copy link
Contributor

use a more straightforward return value

Signed-off-by: beforetech <mail@before.tech>
@k8s-ci-robot
Copy link

Hi @beforetech. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Feb 26, 2025

/ok-to-test

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.93%. Comparing base (2de17bd) to head (f954f76).
Report is 35 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
client/v3/kv.go 94.44% <100.00%> (ø)
server/auth/jwt.go 79.79% <100.00%> (ø)

... and 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19470      +/-   ##
==========================================
+ Coverage   68.84%   68.93%   +0.09%     
==========================================
  Files         420      420              
  Lines       35762    35779      +17     
==========================================
+ Hits        24622    24666      +44     
+ Misses       9714     9686      -28     
- Partials     1426     1427       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022b9b2...f954f76. Read the comment docs.

@beforetech
Copy link
Contributor Author

Thanks for your review.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, beforetech, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit ac064e8 into etcd-io:main Feb 27, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants