chore: use usetesting instead of tenv #19488
Conversation
|
Skipping CI for Draft Pull Request. |
mmorel-35
force-pushed
the
golangci-lint/usetesting
branch
from
58d5a06 to
7f61818
Compare
mmorel-35
force-pushed
the
golangci-lint/usetesting
branch
from
7f61818 to
eceb130
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #19488 +/- ##
==========================================
- Coverage 68.95% 68.92% -0.03%
==========================================
Files 420 420
Lines 35762 35762
==========================================
- Hits 24658 24648 -10
- Misses 9677 9689 +12
+ Partials 1427 1425 -2 Continue to review full report in Codecov by Sentry.
|
mmorel-35
force-pushed
the
golangci-lint/usetesting
branch
2 times, most recently
from
5323f34 to
2bc72d3
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
golangci-lint/usetesting
branch
from
2bc72d3 to
a8d8c18
Compare
| oldenv := os.Getenv("EXPECT_DEBUG") | ||
| defer os.Setenv("EXPECT_DEBUG", oldenv) |
There was a problem hiding this comment.
can you please explain why remove these two lines?
There was a problem hiding this comment.
using t.SetEnv is doing the same thing with cleanup at the end of the test execution
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This is migrating from tenv to usetesting
Closes #19485