Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: delete grpcproxy workflow #19496

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 27, 2025

These jobs are already running on the Prow infrastructure. We should be able to remove them to declutter the checks run in every pull request.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This job is already running on the Prow infrastructure.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code approved size/M labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (49fbd1e) to head (b1ecb20).
Report is 8 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19496      +/-   ##
==========================================
+ Coverage   68.87%   68.94%   +0.07%     
==========================================
  Files         420      420              
  Lines       35788    35788              
==========================================
+ Hits        24648    24674      +26     
+ Misses       9714     9686      -28     
- Partials     1426     1428       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fbd1e...b1ecb20. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 9b31bdc into etcd-io:main Feb 27, 2025
40 checks passed
@ivanvc ivanvc deleted the remove-grpcproxy-workflows branch February 27, 2025 23:49
@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19551

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

4 participants