Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: Fixing minor typos in v3election.proto and rpc.proto #19498

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ashikjm
Copy link
Contributor

@ashikjm ashikjm commented Feb 27, 2025

Fixing minor typos in the proto files.

Signed-off-by: Ashik J M <ashikjm@gmail.com>
@k8s-ci-robot
Copy link

Hi @ashikjm. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (a423349) to head (f5409c4).
Report is 8 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19498      +/-   ##
==========================================
- Coverage   68.89%   68.84%   -0.05%     
==========================================
  Files         420      421       +1     
  Lines       35788    35901     +113     
==========================================
+ Hits        24656    24716      +60     
- Misses       9709     9760      +51     
- Partials     1423     1425       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a423349...f5409c4. Read the comment docs.

@ashikjm
Copy link
Contributor Author

ashikjm commented Feb 27, 2025

/cc @ahrtr

@k8s-ci-robot k8s-ci-robot requested a review from ahrtr February 27, 2025 13:05
@ahrtr
Copy link
Member

ahrtr commented Feb 27, 2025

/ok-to-test

Thanks for the catch!

@ivanvc
Copy link
Member

ivanvc commented Feb 27, 2025

/retest

@ahrtr
Copy link
Member

ahrtr commented Feb 27, 2025

cc @fuweid @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ashikjm, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 5c147c0 into etcd-io:main Feb 27, 2025
45 checks passed
@ahrtr
Copy link
Member

ahrtr commented Feb 27, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19501

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants