-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add change log 3.7 #19502
Add change log 3.7 #19502
Conversation
Hi @ah8ad3. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ahmad Zolfaghari <ah8ad3@gmail.com>
4b66c85
to
a6b3c93
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 28 files with indirect coverage changes @@ Coverage Diff @@
## main #19502 +/- ##
==========================================
+ Coverage 68.82% 68.87% +0.05%
==========================================
Files 421 421
Lines 35901 35901
==========================================
+ Hits 24708 24726 +18
+ Misses 9762 9747 -15
+ Partials 1431 1428 -3 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ah8ad3.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ah8ad3, ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up on pull request #18356
Added changelog file for version 3.7.
Added
UsageFunc
to deprecations section of changelog version 3.6./cc @ahrtr @ivanvc