Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log 3.7 #19502

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Add change log 3.7 #19502

merged 1 commit into from
Feb 28, 2025

Conversation

ah8ad3
Copy link
Contributor

@ah8ad3 ah8ad3 commented Feb 27, 2025

Follow up on pull request #18356

Added changelog file for version 3.7.
Added UsageFunc to deprecations section of changelog version 3.6.

/cc @ahrtr @ivanvc

@k8s-ci-robot
Copy link

Hi @ah8ad3. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Ahmad Zolfaghari <ah8ad3@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Feb 27, 2025

/ok-to-test

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (5c147c0) to head (a6b3c93).
Report is 2 commits behind head on main.

Additional details and impacted files

see 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19502      +/-   ##
==========================================
+ Coverage   68.82%   68.87%   +0.05%     
==========================================
  Files         421      421              
  Lines       35901    35901              
==========================================
+ Hits        24708    24726      +18     
+ Misses       9762     9747      -15     
+ Partials     1431     1428       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c147c0...a6b3c93. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Feb 27, 2025

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ah8ad3.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ah8ad3, ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 3a2cece into etcd-io:main Feb 28, 2025
42 checks passed
@ah8ad3 ah8ad3 deleted the changelog_v3.7 branch February 28, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants