Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: deflakey TestLeaseGrantKeepAliveOnce #19504

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

tcchawla
Copy link
Contributor

@tcchawla tcchawla commented Mar 1, 2025

Following change deflakes the test here #19500 which can be reproduced by TESTCASE=TestLeaseGrantKeepAliveOnce make test-e2e. This change just increases the timeout and checks if the leader has changed.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @tcchawla. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tcchawla
Copy link
Contributor Author

tcchawla commented Mar 1, 2025

cc @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Mar 1, 2025

please squash the commits, thx

Signed-off-by: tcchawla <tc.chawla2000@gmail.com>
@tcchawla
Copy link
Contributor Author

tcchawla commented Mar 2, 2025

Squashed all the commits on this branch

cc @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Mar 2, 2025

/ok-to-test

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (3a2cece) to head (3e43e45).
Report is 2 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19504      +/-   ##
==========================================
+ Coverage   68.81%   68.85%   +0.03%     
==========================================
  Files         421      421              
  Lines       35901    35901              
==========================================
+ Hits        24706    24720      +14     
+ Misses       9769     9754      -15     
- Partials     1426     1427       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2cece...3e43e45. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, tcchawla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e99f20a into etcd-io:main Mar 3, 2025
40 checks passed
@ahrtr
Copy link
Member

ahrtr commented Mar 3, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ahrtr: new pull request created: #19507

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants