-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify release assets GitHub workflow #19520
Add verify release assets GitHub workflow #19520
Conversation
We can also expand these tests to check that the checksums match and that the binary works (we once manually tested due to a file size in Darwin). We could use https://github.com/uraimo/run-on-arch-action to test different architectures (PPC, mainframe). GitHub also has Windows, Mac (amd64, arm64), and Linux (amd64, arm64) runners. These are the GitHub available runners: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19520 +/- ##
==========================================
+ Coverage 68.80% 68.85% +0.05%
==========================================
Files 421 421
Lines 35901 35901
==========================================
+ Hits 24700 24721 +21
+ Misses 9778 9753 -25
- Partials 1423 1427 +4 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor comments.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be2789c
to
65bc6aa
Compare
Signed-off-by: Ivan Valdes <ivan@vald.es>
65bc6aa
to
215ab98
Compare
/cherry-pick release-3.6 |
@ivanvc: new pull request created: #19539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-3.5 |
@ivanvc: new pull request created: #19540 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This worked correctly during today's releases. /cherry-pick release-3.4 |
@ivanvc: new pull request created: #19545 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This pull request may seem counter-intuitive, as we're trying to move away from GitHub actions. However, there's no current way of running a CI check like this in Prow. It doesn't support running when the repository has a new tag.
This change:
SHA256SUMS
file exists and has the same number of lines as uploaded assets.SHA256SUMS
fileFor both GitHub and Google Cloud assets.
I tested this in my fork:
If the workflow fails, the release lead will get an email from GitHub with the failure.
With this check, we should have more confidence when we enable the automatic undrafting of the release. This addresses issues with corrupted uploads like #19270.
Part of: #18604.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.