Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify release assets GitHub workflow #19520

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 4, 2025

This pull request may seem counter-intuitive, as we're trying to move away from GitHub actions. However, there's no current way of running a CI check like this in Prow. It doesn't support running when the repository has a new tag.

This change:

  • Verifies that the SHA256SUMS file exists and has the same number of lines as uploaded assets.
  • Verifies that the uploaded files match the checksum from the SHA256SUMS file

For both GitHub and Google Cloud assets.

I tested this in my fork:

If the workflow fails, the release lead will get an email from GitHub with the failure.

With this check, we should have more confidence when we enable the automatic undrafting of the release. This addresses issues with corrupted uploads like #19270.

Part of: #18604.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code approved size/M labels Mar 4, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Mar 4, 2025

We can also expand these tests to check that the checksums match and that the binary works (we once manually tested due to a file size in Darwin). We could use https://github.com/uraimo/run-on-arch-action to test different architectures (PPC, mainframe). GitHub also has Windows, Mac (amd64, arm64), and Linux (amd64, arm64) runners.

These are the GitHub available runners:
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (4ef3b37) to head (215ab98).
Report is 24 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19520      +/-   ##
==========================================
+ Coverage   68.80%   68.85%   +0.05%     
==========================================
  Files         421      421              
  Lines       35901    35901              
==========================================
+ Hits        24700    24721      +21     
+ Misses       9778     9753      -25     
- Partials     1423     1427       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef3b37...215ab98. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor comments.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc ivanvc force-pushed the add-verity-released-assets-github-workflow branch from be2789c to 65bc6aa Compare March 4, 2025 22:20
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the add-verity-released-assets-github-workflow branch from 65bc6aa to 215ab98 Compare March 4, 2025 23:23
@ahrtr ahrtr merged commit bf9d6f5 into etcd-io:main Mar 5, 2025
32 checks passed
@ivanvc ivanvc deleted the add-verity-released-assets-github-workflow branch March 5, 2025 17:13
@ivanvc
Copy link
Member Author

ivanvc commented Mar 5, 2025

/cherry-pick release-3.6

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19539

In response to this:

/cherry-pick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member Author

ivanvc commented Mar 5, 2025

/cherry-pick release-3.5

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19540

In response to this:

/cherry-pick release-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member Author

ivanvc commented Mar 5, 2025

This worked correctly during today's releases.

/cherry-pick release-3.4

@k8s-infra-cherrypick-robot

@ivanvc: new pull request created: #19545

In response to this:

This worked correctly during today's releases.

/cherry-pick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

4 participants