Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support diagnostic channels #6353

Open
bjohansebas opened this issue Feb 20, 2025 · 2 comments
Open

Support diagnostic channels #6353

bjohansebas opened this issue Feb 20, 2025 · 2 comments

Comments

@bjohansebas
Copy link
Member

It has been mentioned several times, both in meetings and other issues, to provide support for diagnostic channels, which seems to be something that wants to be integrated into Express no matter what. I am posting this in the issue in case anyone is interested in working on it.

The integration should also be done in the router module.

@dpopp07
Copy link
Contributor

dpopp07 commented Feb 20, 2025

+1 as it could be a useful way to share diagnostic info throughout the ecosystem.

I'm interested in working on this. That said, before getting too far it might be worth discussing the desired direction for both logging and diagnostics overall.

I know @wesleytodd has talked about integrating pino as a logger a few times and while these tools do different things to solve different problems, I imagine they could end up working together. As they are related, I think it would be good to align on the strategy for each of them for v6.

I opened expressjs/discussions#341 to discuss.

@wesleytodd
Copy link
Member

pillarjs/router#96

I am hoping to consolidate this work into the Performance WG since mostly this will be used to observe performance (while recognizing it serves other o11y purposes).

Additionally @simon-id, @Qard, @timfish, and @AbhiPrasad have all either worked in this area or mentioned interest in this work. I will keep this open until we have a better place to discuss, but want to point folks to this Perf WG proposal so we can get everyone involved in a productive way with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants