chore: add pull request template #6110
Conversation
|
cc: @expressjs/triagers @expressjs/express-tc |
| - [ ] I have updated the documentation accordingly | ||
| - [ ] I have added tests to cover my changes | ||
| - [ ] All new and existing tests passed | ||
| - [ ] My commits follow [conventional commits](https://www.conventionalcommits.org/) format |
There was a problem hiding this comment.
while I love the idea of following conventional commits, maybe we should agree on it first.
There was a problem hiding this comment.
I have been just editing the commit messages as I merge things this week. Since we didn't have clear guidance on it, I figured just starting the ball rolling on using them was alright. I agree we should agree on it though, especially before adopting the release tooling we want which would likely rely on them. I can make an ADR for it soon.
|
Wouldn't it be better to do it at the organizational level rather than just in one repository? |
It might. I have this PR open as well: expressjs/.github#9 I think the thing that is interesting is that for |
No description provided.