Tags: facebook/hhvm
Tags
Rename ThriftServer::addIOThreadPoolObserver to ThriftServer::addIOTh… …readPoolObserverFactory Reviewed By: AkramaMirza Differential Revision: D44304594 fbshipit-source-id: 67cbd0341864004f006c4360b03a351c3aa0f3ec
Updating submodules Summary: GitHub commits: facebook/fbthrift@79adcae facebook/proxygen@88137a4 facebookincubator/velox@fb47134 Reviewed By: bigfootjon fbshipit-source-id: 80744047f3aecb409f80f114cd7bbe6d56471dd6
Automatic T deduction of asValueStruct Summary: This helps reduce whole bunch of redudnant type information. Reviewed By: Mizuchi, iahs Differential Revision: D44276311 fbshipit-source-id: 5af31a53df88cca0d05a19996c9b4920923348fa
Fix lints in t_structured::try_append_field
Summary:
`t_structured::try_append_field` takes the field by an rvalue reference but moves it conditionally and the caller often needs to access the field if it wasn't moved. This results in multiple lint errors at each call site, e.g.
```
'field' used after it was moved
fbcode/thrift/compiler/parse/parsing_driver.cc:644:12: move occurred here
if (!s.try_append_field(std::move(field))) {
^
```
This doesn't add any value and can mask real bugs.
Replace the rvalue reference with an lvalue reference which makes more sense anyway since this is effectively an in/out parameter. It is possible to do something more fancy e.g. passing field by value and then returning it on failure but that will make usage more awkward for little benefit as the use-after-move errors in the compiler are easy to debug.
Rename the `elem` argument to `field` while at it.
Reviewed By: iahs
Differential Revision: D44228690
fbshipit-source-id: b31a2f900c2471ab4ea8f7a50095266bcdd9555c
Updating submodules Summary: GitHub commits: facebook/fbthrift@f1e05d4 facebookexperimental/rust-shed@2c0609b Reviewed By: jurajh-fb fbshipit-source-id: 46288884d2f5b93a66567ec0363117c269d766ba
let HHVM extension owners specify an oncall rotation for their extension Summary: Optional for now. New extensions should register an oncall. We will make relevant teams accountable for existing extensions too. Reviewed By: ricklavoie Differential Revision: D44188698 fbshipit-source-id: 3f1405109357c5e07da19c0c3b2f6a1f59fa6adf
upgrade pyre version in `fbcode/thrift` - batch 1 Differential Revision: D44182688 fbshipit-source-id: efbccbad8036baa5830410f9091599a14485abd9
Updating submodules Summary: GitHub commits: facebook/CacheLib@8b98b6e facebook/fb303@dea5d00 facebook/fbthrift@ab5dd63 facebook/folly@e288b43 facebook/litho@412ca44 facebook/mcrouter@3b31830 facebook/proxygen@b663997 facebook/wangle@30304c9 facebook/watchman@1a5e610 facebookexperimental/edencommon@4c30e6e facebookexperimental/rust-shed@349a3c6 facebookincubator/fizz@b35b6da facebookincubator/katran@cbefcad facebook/mvfst@68a198e facebookincubator/velox@c98c0a7 fairinternal/egohowto@6bf7811 pytorch/FBGEMM@c7cddec Reviewed By: jurajh-fb fbshipit-source-id: 55e049c90043f451d8fea19c376e10b76717a477
PreviousNext