Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 0100: remove batch balancer-related functionality #12902

Open
BigLep opened this issue Feb 14, 2025 · 1 comment · May be fixed by #12919
Open

FIP 0100: remove batch balancer-related functionality #12902

BigLep opened this issue Feb 14, 2025 · 1 comment · May be fixed by #12919

Comments

@BigLep
Copy link
Member

BigLep commented Feb 14, 2025

Done Criteria

  1. Remove batch balancer, associated config and branching logic
  2. Aggregate where possible, batch otherwise where possibleAggregation constraints remain:
  • For ProveCommitAggregate and ProveCommitSectors3, the minimum sectors for aggregation is 4 and the maximum is 819
  • For ProveCommitSectorsNI (Non-Interactive) the minimum sectors for aggregation is 1 and the maximum is 65

Decision matrix should now be:

  • PreCommit: prefer batching wherever possible
  • Commit:
    • Prefer aggregation on commit where there are at least 4 sectors available for a single commit
    • Otherwise batch where possible

Why Important

See https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0100.md#change-motivation

Notes

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Feb 14, 2025
@tediou5 tediou5 linked a pull request Feb 25, 2025 that will close this issue
8 tasks
@BigLep BigLep moved this from 🐱 Todo to ⌨️ In Progress in nv25 Track Board Feb 26, 2025
@rvagg
Copy link
Member

rvagg commented Feb 26, 2025

More comprehensive description:

  1. Remove batch balancer, associated config and branching logic
  2. Aggregate where possible, batch otherwise where possibleAggregation constraints remain:
  • For ProveCommitAggregate and ProveCommitSectors3, the minimum sectors for aggregation is 4 and the maximum is 819
  • For ProveCommitSectorsNI (Non-Interactive) the minimum sectors for aggregation is 1 and the maximum is 65

Decision matrix should now be:

  • PreCommit: prefer batching wherever possible
  • Commit:
    • Prefer aggregation on commit where there are at least 4 sectors available for a single commit
    • Otherwise batch where possible

@BigLep BigLep moved this from ⌨️ In Progress to 🔎 Awaiting Review in nv25 Track Board Feb 27, 2025
@rjan90 rjan90 moved this from 📌 Triage to ⌨️ In Progress in FilOz Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⌨️ In Progress
Status: 🔎 Awaiting Review
Development

Successfully merging a pull request may close this issue.

2 participants