feat(miner): remove batch balancer-related functionality #12919
+12
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tediou5 : no pressure, but is this ready for review? If so, lets move it out of draft to make it clear. Thanks. |
|
@tediou5 : thanks for working on this. We wanted to make sure you saw #12902 (comment) |
@BigLep Got it, let me check the part of aggregation. |
|
@BigLep Yes, I think it's ready for review now. I'd like to get some feedback as well since I'm not very familiar with this part of the code, and I'm a bit worried I might have missed something. |
tediou5
force-pushed
the
feat/lotus-miner/impl-fip0100
branch
from
e01b8bf to
6426700
Compare
|
Please run Also, this appears to now be submitting batches that are too large (See the failing tests):
I think this is the max batch size for precommit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
close #12902
Proposed Changes
Removed BatchPreCommitAboveBaseFee, AggregateAboveBaseFee, and the related checks.
The MinCommitBatch is actually constrained by the SNARK circuits, so it will remain at 4 without change:
You need 4 or more sectors to ensure that the verification time for aggregated proofs is smaller than for batched proofs.
You need 13 sectors or more to ensure that the aggregated proof size is smaller than the batched proof size.
The MaxCommitBatch limit comes from the original (FIP-0013), and it seems there's not much incentive to modify it, so these two parameters will remain unchanged.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: