feat(cli): standardise a top level output format for all lotus CLIs #12868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
rjan90
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
|
Thank you for your pull request, @shobit000! I've refined the title to ensure it meets the "PR title check" criteria. I've also assigned Masih as the reviewer for your PR. He will review it shortly and provide feedback. |
|
ok |
masih
requested changes
Feb 4, 2025
|
any updates ?? |
masih
requested changes
Feb 10, 2025
.github/workflows/stale-branches
Outdated
| @@ -0,0 +1,33 @@ | |||
| # .github/workflows/stale-branches.yml | |||
|
I'm going to approve and run workflows so @shobit000 can see the CI state. (From a safety regard, since the PR is from a fork, this will use GitHub runners.) |
|
@shobit000 : when CI is passing, please go ahead and re-request review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This PR addresses issue #12616 regarding the standardization of the output format for all Lotus CLIs.
Proposed Changes
The changes include:
This pull request includes several changes to the CLI commands and introduces a standardized output format for all Lotus CLI commands. The most important changes include the removal of some developer and network commands, the addition of new CLI commands for managing the chain index and miner, and the introduction of a utility function for formatting output.
Motivation
Motivation:
The --output flag facilitates programmatic use of Lotus CLI commands, supporting JSON and text formats for easier parsing and processing with tools like jq.
Changes:
cli/chain.go: Updated to support the --output flag and format the output accordingly.
cli/miner/miner.go: Updated to support the --output flag and format the output accordingly.
cli/cmd.go: Updated to support the --output flag and format the output accordingly.
cli/index.go: Updated to support the --output flag and format the output accordingly.
cli/util/output.go: New file that contains the implementation of the FormatOutput function.