-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markduckworth/ppl mep #8801
base: feat/pipelines
Are you sure you want to change the base?
Markduckworth/ppl mep #8801
Conversation
…ort issues and makes code organization across /pipelines and /lite/pipeliens
… auguments the Firestore and Query classes.
…are abstract classes not interfaces. Removed extraneous Pipeline.sort overload
…into markduckworth/ppl-mep
… to expression using map(...) or array(...)
…into markduckworth/ppl-mep
|
…ss rather than the Query class
…n from a classic query
… <name>. Meets API design
…pipeline without being wrapped in a call to constant(...)
* <p>The returned Promise can be used to track the progress of the pipeline execution | ||
* and retrieve the results (or handle any errors) asynchronously. | ||
* | ||
* <p>The pipeline results are returned as a list of {@link PipelineResult} objects. Each {@link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part needs a rewrite.
* @internal | ||
* @param value | ||
*/ | ||
function fieldOfOrExpr(value: unknown): Expr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fieldOrExpr
?
You probably need to run yarn prettier? |
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.