fix: write off amount on pos

[diptanilsaha]

Fixed write-off on POS, where the User can write off the change amount if paid using Cash Mode of Payment.

Co-authored by @devdiogenes

#45607

[devdiogenes]

Thanks for mentioning

[HarryPaulo]

In this code block I see a conflict between the writeoff calculated on the POS invoice and the writeoff applied automatically...

erpnext/erpnext/controllers/taxes_and_totals.py

Line 910 in f05c1d7

if write_off_limit and abs(self.doc.outstanding_amount) <= write_off_limit:

I will run tests soon and put all the observation points here.

[diptanilsaha]

@HarryPaulo Thank you for bringing this to my attention. It appears that the logic for consolidation is incorrect.

However, I believe there should be a limit on the write-off amount for each POS invoice. What do you think about this?

[diptanilsaha]

@devdiogenes any updates?

[HarryPaulo]

Can a POS invoice be partially paid? i belive Yes.

I think the "write_off_limit" parameter can generate many operational errors, as it mischaracterizes what the user would have to apply when making the POS Invoice, looking at the outstanding balance according to a limit...

What if "write_off_limit" was a validation of the writeoff limit applied to POS Invoice and Sales Invoice instead of marking write_off_outstanding_amount_automatically?

Tomorrow I will take a few hours and get your code and do some testing

[HarryPaulo]

I understand the practicality of this parameter...

In the POS profile, the "write_off_limit" field should have its default value = 0, this would leave the feature disabled by default, if the user applied a limit value, the system would perform this "writeoff" automatically.

When applying the "write_off_outstanding_amount_automatically" the system must consider the "change_amount".

1. When creating a sales invoice where is_pos=1 and is_consolidated=0, it must apply the rule to the sales invoice.

2. When creating a POS invoice, it must apply the rule.

When consolidating, the system should only ADD the amounts made in the POS invoice and consolidate them in the sales invoices, I believe that it should not apply this writeoff rule.

[HarryPaulo]

I made a POS Invoice with grand total 18,90.

$20 was give as money, 0,1 write off and $1 change amount.

On cosolidate, change amount was wrong calculated,

Sales Invoice: $20 was give as money, 0,1 write off and $1,1 change amount.

20250224_110342.mp4

Resulting a wrong Outstanding Amount

[HarryPaulo]

Change amount is not calculated correctly on try to create directly the sales, is impossible to set write off and change amount together

Examples:

Directly trying to set change amount and writeoff os Sales Invoice

20250224_122014.mp4

Directly trying to set change amount and writeoff os POS Invoice

20250224_122137.mp4

[HarryPaulo]

Tryinig to use auto write off and set the change amount, not work too...

20250224_125256.mp4

[diptanilsaha]

@HarryPaulo Thanks for your feedback. I need some more time to complete this feature. Keep testing and let me know if you find any more bugs.

[diptanilsaha]

@HarryPaulo we are integrating Sales Invoice with POS. So, there might be some delay in releasing this feature as some rework might be required.

[HarryPaulo]

@diptanilsaha POS Invoice will still exists? because POS invoice is very important for operations with big quantity of sales per day...

[diptanilsaha]

Yes, the POS Invoice will be available. By default, the POS will use the POS Invoice. However, users can choose to use the Sales Invoice in the POS Profile Configurations.

[HarryPaulo]

We currently have two POS systems, the old Offline POS and the current online one.

For the offline POS, we use this option to define whether that environment will create a sales invoice or POS Invoice.

I don't know if it would be ideal to configure this in the POS Profile or in the POS Settings

However, when releasing your change, I will make the adaptations and follow the new format.