fix: validate return invoice qty #46038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exceeding voucher item quantity and disallow zero-quantity returns for fully returned items.
Bhavan23
changed the title
Bhavan23
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
nabinhait
requested changes
Mar 5, 2025
| return | ||
|
|
||
| validate_returned_items(doc) | ||
|
|
||
|
|
||
| def validate_returned_invoice_items_qty(doc): |
There was a problem hiding this comment.
There is already a function named validate_quantity for validating returned qty. Please debug that function and make the fix.
|
Closing this PR and opening a new one: PR #46451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: 31768
Before:
before.webm
After:
after.webm
Backport Needed: v15