Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debit and Credit mismatch on transaction currency debit and credit values #46064

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Feb 21, 2025

Issue

Debit and Credit values in Transaction currency have a slight mismatch on high precision exchange rates. This is un-fixable on the current approach.
Screenshot from 2025-03-10 10-40-14

Solution

Instead of calculating Transaction Debit and Credit from base currency, use values directly from parent document.

todo:

  • doctype specific logic for:
    • purchase invoice
    • sales invoice
    • journal entry
    • payment entry
  • use common method of remaining ones

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 21, 2025
@ruthra-kumar ruthra-kumar force-pushed the transaction_currency_from_parent_document branch from 4fd1f4c to 6b3e7d4 Compare February 28, 2025 10:53
@ruthra-kumar ruthra-kumar self-assigned this Mar 4, 2025
@ruthra-kumar ruthra-kumar force-pushed the transaction_currency_from_parent_document branch 5 times, most recently from 672fed3 to 5ec4cb9 Compare March 7, 2025 11:37
@ruthra-kumar ruthra-kumar removed the needs-tests This PR needs automated unit-tests. label Mar 7, 2025
@ruthra-kumar ruthra-kumar force-pushed the transaction_currency_from_parent_document branch from 21e649d to f1d8fee Compare March 8, 2025 06:15
@ruthra-kumar ruthra-kumar merged commit f5d061d into frappe:develop Mar 8, 2025
13 checks passed
ruthra-kumar added a commit that referenced this pull request Mar 8, 2025
…-46064

fix: Debit and Credit mismatch on transaction currency debit and credit values (backport #46064)
@ruthra-kumar
Copy link
Member Author

@mergify backport version-15

Copy link
Contributor

mergify bot commented Mar 8, 2025

backport version-15

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Mar 8, 2025
fix: Debit and Credit mismatch on transaction currency debit and credit values (backport #46064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant