-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Debit and Credit mismatch on transaction currency debit and credit values #46064
Merged
ruthra-kumar
merged 19 commits into
frappe:develop
from
ruthra-kumar:transaction_currency_from_parent_document
Mar 8, 2025
Merged
fix: Debit and Credit mismatch on transaction currency debit and credit values #46064
ruthra-kumar
merged 19 commits into
frappe:develop
from
ruthra-kumar:transaction_currency_from_parent_document
Mar 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fd1f4c
to
6b3e7d4
Compare
672fed3
to
5ec4cb9
Compare
21e649d
to
f1d8fee
Compare
6 tasks
ruthra-kumar
added a commit
that referenced
this pull request
Mar 8, 2025
…-46064 fix: Debit and Credit mismatch on transaction currency debit and credit values (backport #46064)
@mergify backport version-15 |
✅ Backports have been created
|
6 tasks
ruthra-kumar
added a commit
that referenced
this pull request
Mar 8, 2025
fix: Debit and Credit mismatch on transaction currency debit and credit values (backport #46064)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Debit and Credit values in Transaction currency have a slight mismatch on high precision exchange rates. This is un-fixable on the current approach.

Solution
Instead of calculating Transaction Debit and Credit from base currency, use values directly from parent document.
todo: