Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add base_outstanding and base_paid_amount and store value in company currency #46112

Closed
wants to merge 5 commits into from

Conversation

Sugesh393
Copy link
Contributor

@Sugesh393 Sugesh393 commented Feb 24, 2025

Issue:
Steps to reproduce:

  • Create two new Payment Terms and create Payment Term Template with these terms
  • Create an Invoice with foreign currency Customer and use the newly created Payment Term Template.
  • Pay first term fully and second term half.
  • While checking data in Account Receivable report for this customer after enabling based_on_payment_terms, extra payment row added and values were wrong.
  • If we enable in_party_currency, values were correct.

Before:

accounts_receivable_report_bfr.mp4

After:

account_receivable_report_afr.mp4

Back port needed for version-15

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 24, 2025
@nabinhait
Copy link
Member

@Sugesh393, why is it in the draft? Is there anything pending?

@Sugesh393
Copy link
Contributor Author

We are internally reviewing changes and the changes needed patch to update existing records.
Will open the PR after completing patch @nabinhait

@Sugesh393
Copy link
Contributor Author

Closing this PR and opening it as #46440

@Sugesh393 Sugesh393 closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants