Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unit Price Items #46214

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

marination
Copy link
Collaborator

@marination marination commented Feb 28, 2025

no-docs
Closes #36012 (Refer for more Info)
Revival of #36024 in a hopefully cleaner way

WIP: 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧

  • Screenshot 2025-02-28 at 11 07 53 PM
  • We now flag the record as has_unit_price_items if allowed via Settings and if it has any 0 qty items
  • We don't maintain row wise flags anymore. The user is free to leave the qty as 0. Nothing more
  • They will be reminded that the record contains unit price items
    Screenshot 2025-02-28 at 11 12 59 PM

Users can decide to manage their Transactions in two ways

  1. Keep updating the Qty in the Order ["Sales Order", "Purchase Order"]
    • Once a portion of work is done, users can update the qty in the SO/PO -> Then create SI/PI for the updated qty
  2. Keep the Qty 0 [SO, PO, RFQ, SQ, Quotation]
    • For those who might think constant updation SO is adding friction OR are not particular about tracking OR cannot update quantities in certain documents after submission, you can leave the quantities to be 0.
    • They can keep making Invoices with actual quantities against the SO/PO with 0 qty. The Billed % will always show as 0
    • The SO/PO will have to be manually Closed. Since there's no way to know when the Order is truly Completed.

TODO:

  • Extend to Purchase
  • Tests
  • Docs

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 28, 2025
@marination marination force-pushed the unit-price-contract-2 branch from 5344112 to 8f96c0b Compare March 12, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Price Contract
1 participant