Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make 'company_tax_id' and 'company_fiscal_code' as mandatory #46344

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

Bhavan23
Copy link
Contributor

@Bhavan23 Bhavan23 commented Mar 5, 2025

Issue:
When the company country is Italy, the existing validation validates the company tax ID or fiscal code to be mandatory.
As the Company Tax ID is used as e-invoice naming, error occurs when company tax ID is not set

Ref: 31829

Before:

before.webm

After:

after.webm

Backport Needed: v15

@Bhavan23 Bhavan23 requested a review from ruthra-kumar as a code owner March 5, 2025 14:43
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 5, 2025
@ruthra-kumar ruthra-kumar self-assigned this Mar 11, 2025
@ruthra-kumar ruthra-kumar enabled auto-merge March 11, 2025 11:25
@ruthra-kumar ruthra-kumar merged commit 4483512 into frappe:develop Mar 11, 2025
12 of 13 checks passed
ruthra-kumar added a commit that referenced this pull request Mar 11, 2025
…-46344

fix: make 'company_tax_id' and 'company_fiscal_code' as mandatory (backport #46344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants