Fix: add parenttype condition to payment schedule query in accounts receivable report #46370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Mar 12, 2025
|
🎉 This PR is included in version 14.83.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ruthra-kumar
added
backport develop
ruthra-kumar
pushed a commit
that referenced
this pull request
Mar 13, 2025
…eceivable report (backport #46370)
ruthra-kumar
pushed a commit
that referenced
this pull request
Mar 13, 2025
…eceivable report (backport #46370) (#46499) Fix: add parenttype condition to payment schedule query in accounts receivable report (#46370) fix: add parenttype condition to payment schedule query in accounts receivable report (cherry picked from commit f311a0f) Co-authored-by: Shanuka Hewage <89955436+Shanuka-98@users.noreply.github.com>
diptanilsaha
pushed a commit
to diptanilsaha/erpnext
that referenced
this pull request
Mar 13, 2025
…eceivable report (backport frappe#46370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that the
get_payment_termsfunction correctly filters records by adding the missing condition:By including
ps.parenttype = '{row.voucher_type}', the function properly associates payment terms with the correct document type, preventing incorrect outstanding amount calculations.Impact of the Fix
closes #46367
backport version-14
backport version-15