Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment entry): fetch default bank account based on company #46379

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix(payment entry): fetch default bank account based on company #46379

merged 1 commit into from
Mar 12, 2025

Conversation

venkat102
Copy link
Contributor

Issue:
Different company bank accounts are being fetched while creating Payment Entry from Sales Invoice
ref: 33189

Steps to reproduce:

  • Create 2 companies Company A and Company B
  • Create a default bank account for company Company A
  • Default bank account and default cash account shouldn't be mentioned in Company B
  • There should be 2 or more accounts with account type bank and cash.
  • Create a sales invoice for Company B
  • Create Payment Entry from sales invoice, Company A's bank and bank account will be fetched into Company B's Payment Entry

Before:

bank-account-Issue.mp4

After:

bank-account-fix.mp4

Backport needed for v15 and v14

@venkat102 venkat102 requested a review from ruthra-kumar as a code owner March 6, 2025 20:26
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 6, 2025
@ruthra-kumar ruthra-kumar self-assigned this Mar 11, 2025
@nabinhait nabinhait merged commit b72f6f5 into frappe:develop Mar 12, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@venkat102 @mergify
fix(payment entry): fetch default bank account based on company (#46379)
24a4cff 
(cherry picked from commit b72f6f5)
@mergify mergify bot mentioned this pull request Mar 12, 2025
Merged
nabinhait pushed a commit that referenced this pull request Mar 12, 2025
@mergify @venkat102
fix(payment entry): fetch default bank account based on company (back…
1371199 
…port #46379) (#46471)

fix(payment entry): fetch default bank account based on company (#46379)

(cherry picked from commit b72f6f5)

Co-authored-by: Venkatesh <47534423+venkat102@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Mar 12, 2025
@frappe-bot
chore(release): Bumped to Version 15.54.4
08f47b6 
## [15.54.4](v15.54.3...v15.54.4) (2025-03-12)

### Bug Fixes

* `base_net_rate` Required to Check Valid Range (backport [#46332](#46332)) ([#46382](#46382)) ([877d5bd](877d5bd))
* **account:** update account number from parent company ([428aedc](428aedc))
* Allow rename prospect doctype ([#46352](#46352)) ([de46165](de46165))
* auto email report creation ([#46343](#46343)) ([5cc251a](5cc251a))
* backport translations from develop ([#46428](#46428)) ([9c70376](9c70376))
* calculate due date based on payment term (backport [#46416](#46416)) ([#46479](#46479)) ([7f14744](7f14744))
* change fieldname for cash_flow to export (backport [#46353](#46353)) ([#46366](#46366)) ([23c4252](23c4252))
* check if set_landed_cost_based_on_purchase_invoice_rate is enabled before running patch ([7047fe2](7047fe2))
* clear cashe on employee hierarchy change to reflect updated permissions ([4dfdb2b](4dfdb2b))
* consider account freeze date in recalculate_amount_difference_field patch ([8b67527](8b67527))
* consider stock freeze date in recalculate_amount_difference_field patch ([8264d42](8264d42))
* credit note creation during pos invoice consolidation (backport [#46277](#46277)) ([#46469](#46469)) ([a4b8b4c](a4b8b4c))
* do not recalculate qty for batch items during reposting ([bac36f3](bac36f3))
* doctype name ([1dcbdf3](1dcbdf3))
* enable no copy for serial no field ([3f9df2f](3f9df2f))
* error in production analytics report ([db6ae61](db6ae61))
* error when creating delivery note from pick list ([#46417](#46417)) ([0b92101](0b92101))
* filter batches that going to be zero ([ac97489](ac97489))
* incorrect category in list ([002685f](002685f))
* make 'company_tax_id' and 'company_fiscal_code' as mandatory ([229f4d3](229f4d3))
* not able to save work order with alternative item ([9554a49](9554a49))
* **payment entry:** fetch default bank account based on company (backport [#46379](#46379)) ([#46471](#46471)) ([1371199](1371199))
* pricing rule not ignored in Sales Order ([#46248](#46248)) ([8def42f](8def42f))
* rare precision issue preventing submission of subcontracting order ([6419d02](6419d02))
* recalculate_amount_difference_field patch ([f247f02](f247f02))
* remove no copy for serial no field of purchase receipt item ([baa564f](baa564f))
* rename sla fields patch ([73f11cf](73f11cf))
* rename sla fields patch ([#46465](#46465)) ([5edbd88](5edbd88))
* rename_sla_fields patch ([7bc7557](7bc7557))
* run bank reconciliation as a background job to prevent request timeout ([739cd18](739cd18))
* set correct account currency for deferred expence account in PI ([f96848a](f96848a))
* show remaining qty on 'Complete Job' button instead of full qty ([79e6550](79e6550))
* sla fields patch ([0d044bc](0d044bc))
* stock balance in and out value ([c2001e9](c2001e9))
* **test:** incorrect transaction exchange rate in test case ([b76c968](b76c968))
* typo in sales_invoice_print ([b610621](b610621))
* uom reverts to default upon selecting do not explode ([#45693](#45693)) ([6b1d209](6b1d209))
* validate accounting dimension company in Journal Entry & Stock Entry (backport [#46204](#46204)) ([#46369](#46369)) ([c816f9b](c816f9b))
* validate last_gl_update exists before comparing (backport [#46464](#46464)) ([#46468](#46468)) ([3cef94e](3cef94e))
* validations and account type filter for `Tax Withholding Category` ([#46207](#46207)) ([cc30a01](cc30a01))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait

@ruthra-kumar ruthra-kumar

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venkat102 @nabinhait @ruthra-kumar