Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounting/regional): allow chart_of_account.get_chart to be whilelist #46386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Mar 7, 2025

Please provide enough information so that others can review your pull request:

Allow complete autonomy for external application to propose other charts of accounts than those already embeded in erpnext/accounts/doctype/account/chart_of_accounts/verified

Explain the details for making this change. What existing problem does the pull request solve?

As erpnext.accounts.doctype.acount.chart_of_accounts.get_charts_for_country is already whilelist this is unfortunatly the half of the needed process for customization done by external application (like regionnal application erpnext_france for exemple).
Because select list of chart of account available in setup withard is provided by chart_of_accounts.get_charts_for_country, , so here an custom application can add other entry, but latter the install process use chart_of_accounts.get_chart to get the json chart_of_account.

no-docs

@FHenry FHenry requested a review from ruthra-kumar as a code owner March 7, 2025 11:42
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant