chore(automation) Prefix steps and components logs w/ run_id and name #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddubey
changed the title
kddubey
commented
Feb 26, 2025
Comment on lines
+41
to
+43
| @cached_property | ||
| def logger(self): | ||
| run_id = self.context.run_id |
There was a problem hiding this comment.
just need self.context.run_id once. double checking it's safe and correct to cache this?
jennmueng
approved these changes
Mar 4, 2025
| def logger(self): | ||
| run_id = self.context.run_id | ||
| name = f"{type(self).__module__}.{type(self).__qualname__}" | ||
| prefix = f"[{run_id=}] [{name}] " |
There was a problem hiding this comment.
didn't know about this syntax before, nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it's a bit easier to query logs. currently tested via local run of relevant warnings where I used
self.loggerin the components (see example below)lmk if i should also change the autofix components to use
self.loggerin a follow-up PRExample log from Autofix
Before:
After:
Example log from a component in relevant warnings
Before:
After: