Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(anomaly detection): Remove Fixed Window Logic #2017

Closed
wants to merge 13 commits into from
Closed

chore(anomaly detection): Remove Fixed Window Logic #2017

wants to merge 13 commits into from
+1,667 −1,559

Conversation

aayush-se
Copy link
Member

@aayush-se aayush-se commented Feb 27, 2025 •
edited
Loading

Draft PR waiting for Combined Logic to be implemented then will rebase these changes on top of that

  • Comment out calculations of the fixed window for the Dynamic Window
  • Ensures that we only use the SuSS window for the MP calculations
  • Enables simple rollback to using Dynamic Window logic again in the future

@aayush-se aayush-se requested a review from a team as a code owner February 27, 2025 00:02
@aayush-se aayush-se assigned ram-senth and unassigned ram-senth Feb 27, 2025
@aayush-se aayush-se requested a review from ram-senth February 27, 2025 00:06
@aayush-se aayush-se marked this pull request as draft February 27, 2025 00:27
@aayush-se aayush-se force-pushed the anomaly-detection/remove-dynamic-window branch from b219daf to aec600a Compare March 4, 2025 18:53
@ram-senth ram-senth force-pushed the anomaly-detection/remove-dynamic-window branch from 5a7bc24 to f4eb985 Compare March 4, 2025 21:25
@aayush-se aayush-se closed this Mar 5, 2025
@aayush-se
Copy link
Member Author

Completed as part of combined scorer PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ram-senth ram-senth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayush-se @ram-senth